Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recordingDb: remove koanf for config #358

Merged
merged 2 commits into from
Sep 13, 2024
Merged

recordingDb: remove koanf for config #358

merged 2 commits into from
Sep 13, 2024

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented Sep 12, 2024

this will be done in a different struct in nitro

@cla-bot cla-bot bot added the s CLA signed label Sep 12, 2024
@tsahee tsahee mentioned this pull request Sep 12, 2024
Merged
PlasmaPower
PlasmaPower approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit de3d875 into master Sep 13, 2024
7 checks passed
@tsahee tsahee deleted the recorddb_config branch September 13, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
design-approved s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsahee @PlasmaPower